Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement basic interval method #163

Merged
merged 3 commits into from
Oct 9, 2021
Merged

implement basic interval method #163

merged 3 commits into from
Oct 9, 2021

Conversation

sergeysova
Copy link
Member

@sergeysova sergeysova commented Aug 4, 2021

#159

Description

Checklist for a new method

  • Create directory for new method in root in param-case
  • Place code to {method-name}/index.js in CommonJS export in camelCase named export
  • Add types to {method-name}/index.d.ts
  • Add tests to {method-name}/{method-name}.test.ts
  • Add fork tests to {method-name}/{method-name}.fork.test.ts
  • Add type tests to test-typings/{method-name}.ts
    • Use // @ts-expect-error to mark expected type error
    • import { expectType } from 'tsd' to check expected return type
  • Add documentation in {method-name}/reade.md
    • Add header Patronum/MethodName
    • Add section with overloads, if have
    • Add Motivation, Formulae, Arguments and Return sections for each overload
    • Add useful examples in Example section for each overload
  • Add section to README.md in root
    • Add method to table of contents - [MethodName](#methodname)
    • Add section ## [MethodName](/method-name 'Documentation')
    • With summary and simple example

interval/index.d.ts Outdated Show resolved Hide resolved
@sergeysova sergeysova force-pushed the add-interval-method branch 4 times, most recently from 13309c6 to 0523c1b Compare September 24, 2021 22:19
@sergeysova sergeysova force-pushed the add-interval-method branch from 0523c1b to 0d00570 Compare October 9, 2021 20:02
@sergeysova sergeysova marked this pull request as ready for review October 9, 2021 20:38
@sergeysova sergeysova merged commit aa0c87a into main Oct 9, 2021
@sergeysova sergeysova deleted the add-interval-method branch October 9, 2021 20:39
@sergeysova sergeysova added the feature New functionality label Oct 9, 2021
@sergeysova sergeysova added this to the v2.0 milestone Nov 14, 2021
@sergeysova sergeysova mentioned this pull request Nov 14, 2021
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants